Avoid specifying "last import wins" for MBEs #2057
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
traviscross
commented
Oct 22, 2025
src/macros-by-example.md
Outdated
Comment on lines
395
to
396
| > [!NOTE] | ||
| > `rustc` currently prefers the last macro in case of conflict. Don't rely on this. This behavior is unusual, as imports in Rust are generally order-independent. This behavior of `macro_use` may change in the future. |
There was a problem hiding this comment.
If there's a good issue to cite for this, we can cite it here.
There was a problem hiding this comment.
I've opened rust-lang/rust#148025 for this.
There was a problem hiding this comment.
Thanks. Added it here.
traviscross
force-pushed
the
TC/loosen-mbe-last-macro-imported-wins
branch
from
97cadcf to
5b19599
Compare
Currently, for `macro_use`, the last macro imported wins. This may be something that we consider to be a bug. Rather than documenting this normatively, then, let's stay normatively silent on that behavior and document the details of the situation with `rustc` in an admonition.
traviscross
force-pushed
the
TC/loosen-mbe-last-macro-imported-wins
branch
from
5b19599 to
d5c876c
Compare
|
This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
rustbot
removed
the
S-waiting-on-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, for
macro_use, the last macro imported wins. This may be something that we consider to be a bug. Rather than documenting this normatively, then, let's stay normatively silent on that behavior and document the details of the situation withrustcin an admonition.cc @ehuss @petrochenkov #1886 (comment)